funky-eyes commented on PR #7559: URL: https://github.com/apache/incubator-seata/pull/7559#issuecomment-3216962878
1. The functionality of UnregisterRMRequest should be separated into an individual PR, with the current PR focusing solely on resolving the issue where tableMetaRefresh does not terminate. 2. In NettyClientChannelManager, cache the rpcContext for a channel based on the response from RegisterRMResponse, and also cache the server version number. You may refer to the design of the RpcContext class for this implementation. 3. When checking the server version, if it is lower than 2.6.0, output a log indicating that UnregisterRMRequest is not supported by older server versions, and therefore, resources cannot be unregistered. 4. RMClient should provide both destroy and destroyAll interfaces. The destroy interface should accept resource information, construct an UnregisterRMRequest, and send it to the server to unregister the resource. The destroyAll interface should proactively notify the server that the client node is going offline. 5. These points can be split into multiple PRs to improve review efficiency and ensure that each PR is clear and focused. Hi @slievrly, The above is a summary of our previous meeting. Do you have any additional comments or suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
