keepConcentration commented on code in PR #7570: URL: https://github.com/apache/incubator-seata/pull/7570#discussion_r2253988789
########## integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/interceptor/handler/AbstractProxyInvocationHandler.java: ########## Review Comment: I observed that both `SagaAnnotationActionInterceptorHandler` and `TccActionInterceptorHandler`, which inherit from `AbstractProxyInvocationHandler`, explicitly override the `order()` method. To maintain consistency and clarity across all subclasses, I felt it would be more appropriate for `GlobalTransactionalInterceptorHandler` to do the same, rather than relying on a shared implementation in the abstract class. Of course, if you believe it would be better to introduce a shared `order()` implementation in the abstract class, I'm more than happy to follow that direction. I'm open to adjusting the PR according to your preference or the maintainers' conventions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
