funky-eyes commented on code in PR #7536:
URL: https://github.com/apache/incubator-seata/pull/7536#discussion_r2203998722
##########
server/src/test/java/org/apache/seata/server/session/db/DataBaseSessionManagerTest.java:
##########
@@ -69,8 +70,11 @@ public class DataBaseSessionManagerTest {
public static boolean isEnableDruidTest() {
// Unit test triggered a bug in Druid, see the issue
https://github.com/alibaba/druid/issues/4936
- String skipTests = System.getProperty("skip_druid_tests", "true");
- return Boolean.parseBoolean(skipTests);
+ String enable = System.getenv("ENABLE_DRUID_TEST");
Review Comment:
You should use @EnabledIfSystemProperty(named = "druid.version", matches =
"1.2.12") to skip the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]