pjfanning commented on code in PR #2838:
URL: https://github.com/apache/pekko/pull/2838#discussion_r3067948623
##########
actor/src/main/scala/org/apache/pekko/util/ByteString.scala:
##########
@@ -921,6 +1030,67 @@ object ByteString {
}
}
+ override def lastIndexOf[B >: Byte](elem: B, end: Int): Int = {
+ if (end < 0) -1
+ else {
+ val byteStringsLast = bytestrings.size - 1
+
+ @tailrec
+ def find(bsIdx: Int, relativeIndex: Int, len: Int): Int = {
+ if (bsIdx < 0) -1
+ else {
+ val bs = bytestrings(bsIdx)
+ val bsStartIndex = len - bs.length
+
+ if (relativeIndex < bsStartIndex || bs.isEmpty) {
+ if (bsIdx == 0) -1
+ else find(bsIdx - 1, relativeIndex, bsStartIndex)
+ } else {
+ val subIndexOf = bs.lastIndexOf(elem, relativeIndex)
+ if (subIndexOf < 0) {
+ if (bsIdx == 0) -1
+ else find(bsIdx - 1, relativeIndex, bsStartIndex)
+ } else subIndexOf + bsStartIndex
+ }
+ }
+ }
+
+ find(byteStringsLast, math.min(end, length), length)
Review Comment:
applied with most of the suggested changes - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
