nvollmar commented on code in PR #1553:
URL: https://github.com/apache/pekko-connectors/pull/1553#discussion_r3039473500
##########
orientdb/src/main/scala/org/apache/pekko/stream/connectors/orientdb/impl/OrientDbSourceStage.scala:
##########
@@ -48,15 +49,25 @@ private[orientdb] final class
OrientDbSourceStage[T](className: String,
query match {
case Some(q) =>
new Logic {
- override protected def runQuery(): util.List[T] =
- client.query[util.List[T]](new OSQLSynchQuery[T](q))
-
+ override protected def runQuery(): util.List[T] = {
+ val rs = client.query(q)
+ val results = new util.ArrayList[T]()
Review Comment:
OResultSet has estimateSize, maybe could be usable to pre-size the array list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
