pjfanning commented on code in PR #1527:
URL: https://github.com/apache/pekko-connectors/pull/1527#discussion_r2993831457
##########
slick/src/main/scala/org/apache/pekko/stream/connectors/slick/javadsl/Slick.scala:
##########
@@ -153,14 +154,40 @@ object Slick {
* DDL statement is acceptable.
* @param mapper A function to create a result from the incoming element T
* and the database statement result.
+ * @deprecated Use the overload with `java.util.concurrent.Executor` instead.
*/
+ @deprecated("Use flowWithPassThrough with java.util.concurrent.Executor
instead", "2.0.0")
Review Comment:
@He-Pin I'm thinking of removing these newly deprecated methods altogether.
Most ExecutionContext implementations implement ExecutionContextExecutor and
this trait implements the Java Executor interface.
So users will need to recompile their code to use it with our 2.x releases
anyway and it's messy to force them to rewrite their code to cast
`system.dispatcher()` like I've had to do in SlickTest and
DocSnippetFlowWithPassThrough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
