hanishi commented on PR #1494: URL: https://github.com/apache/pekko-connectors/pull/1494#issuecomment-4124332343
Thanks for the thorough review and for merging the PR! I'll continue to support any issues that may arise, and I am happy to address any further suggestions. Regarding the Java DSL durations, I took a closer look, and it appears the Java API already uses `java.time.Duration` throughout. If you do spot any Scala durations leaking into the Java API, please let me know, and I'll fix it. Also, there may be other Google Cloud connectors that don't yet align with the patterns we established here. It might be worth reviewing what we have now across the other modules and seeing where we can improve consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
