raboof commented on code in PR #471:
URL: https://github.com/apache/pekko-grpc/pull/471#discussion_r2164019308
##########
runtime/src/main/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpers.scala:
##########
@@ -111,6 +111,6 @@ object GrpcResponseHelpers {
headers.`Message-Encoding`(writer.messageEncoding.name) ::
GrpcEntityHelpers.trailers(trailer.status, trailer.metadata),
entity = HttpEntity.empty(writer.contentType)
- )
+ ).withAttributes(Map(AttributeKeys.trailer -> trailer))
Review Comment:
if the trailer headers are already written to the `headers`, are they still
needed as `attribute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
