ribafish commented on PR #1028: URL: https://github.com/apache/ofbiz-framework/pull/1028#issuecomment-4134000809
Thanks for the quick fix in #1029! It does resolve the issue for **local** build cache reuse (two consecutive builds on the same machine) — the first build generates keys, the second sees them and skips. However, it doesn't fully address **cross-machine** build cache reuse. On a fresh checkout the keys are empty, so `generateSecretKeys` still generates random values and mutates `security.properties`. Two different machines checking out the same commit will each generate different random keys, producing different `processResources` output and different cache keys for `:compileTestGroovy`, `:checkstyleMain`, `:checkstyleTest`, and `:test`. This PR complements #1029 by removing `generateSecretKeys` from the `build` task graph entirely (it remains available for manual use and `loadAll`), and providing fixed test keys via a test resource file so that `security.properties` is never mutated during builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
