matthiasblaesing commented on PR #9237:
URL: https://github.com/apache/netbeans/pull/9237#issuecomment-4216722830
It seems, that sigtest is position dependent. I can reproduce the problem
locally. Invoking `ant -f enterprise/payara.tooling check-sigtest` gives me:
```
[...]
SignatureTest report
Base version: 2.26
Tested version: 2.27
Check mode: bin [throws removed]
Constant checking: on
Class org.netbeans.modules.payara.tooling.data.JDKVersion
"E1.2 - API type removed" : method public final boolean
org.netbeans.modules.payara.tooling.data.JDKVersion.isOptionSupported(org.netbeans.modules.payara.tooling.server.parser.JvmConfigReader.JvmOption,java.lang.String)
BUILD FAILED
/home/matthias/src/netbeans/nbbuild/templates/projectized.xml:823: Signature
tests return code is wrong (1), check the messages above
Total time: 3 seconds
```
If I then run `ant -f enterprise/payara.tooling gen-sigtest` to regenerate
the sigtest, I get a slightly different file then the one this PR holds:
```diff
diff --git
a/enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
b/enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
index 0fccd8d42bd1..08cc94f11239 100644
---
a/enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
+++
b/enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
@@ -1,5 +1,5 @@
#Signature file v4.1
-#Version 2.26
+#Version 2.27
CLSS public abstract interface java.io.Closeable
intf java.lang.AutoCloseable
@@ -1238,6 +1238,7 @@ CLSS public final
org.netbeans.modules.payara.tooling.data.JDKVersion
meth public boolean equals(java.lang.Object)
meth public boolean ge(org.netbeans.modules.payara.tooling.data.JDKVersion)
meth public boolean gt(org.netbeans.modules.payara.tooling.data.JDKVersion)
+meth public boolean
isOptionSupported(org.netbeans.modules.payara.tooling.server.parser.JvmConfigReader$JvmOption,java.lang.String)
meth public boolean le(org.netbeans.modules.payara.tooling.data.JDKVersion)
meth public boolean lt(org.netbeans.modules.payara.tooling.data.JDKVersion)
meth public int hashCode()
@@ -1248,7 +1249,6 @@ meth public java.util.Optional<java.lang.Short>
getUpdate()
meth public java.util.Optional<java.lang.String> getVM()
meth public java.util.Optional<java.lang.String> getVendor()
meth public short getMajor()
-meth public boolean
isOptionSupported(org.netbeans.modules.payara.tooling.server.parser.JvmConfigReader.JvmOption,java.lang.String)
meth public static org.netbeans.modules.payara.tooling.data.JDKVersion
getDefaultPlatformVersion()
meth public static org.netbeans.modules.payara.tooling.data.JDKVersion
toValue(java.lang.String)
meth public static org.netbeans.modules.payara.tooling.data.JDKVersion
toValue(java.lang.String,java.lang.String)
```
I suggest, that you do that to and amend the commit with that change. That
should clear it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
