jtulach commented on code in PR #9319:
URL: https://github.com/apache/netbeans/pull/9319#discussion_r3036442614
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
-
URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{
matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
Review Comment:
This module is using Graal.js to process proxy configuration files. They are
executed once and running at any JDK21+ is going to be fast enough.
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
-
URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{
matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
- run: ant $OPTS -f platform/core.network test
-
- - name: platform/api.scripting
- run: ant $OPTS -f platform/api.scripting test
-
- - name: ide/libs.graalsdk
- run: ant $OPTS -f ide/libs.graalsdk test
-
- - name: webcommon/libs.graaljs
- run: ant $OPTS -f webcommon/libs.graaljs test
-
- - name: profiler/profiler.oql
- run: ant $OPTS -f profiler/profiler.oql test
-
- - name: java/nashorn.execution
- run: ant $OPTS -f java/nashorn.execution test
-
- - name: java/debugger.jpda.truffle
- run: .github/retry.sh ant $OPTS -f java/debugger.jpda.truffle test
Review Comment:
- thanks to recent work of @lahodaj in #9302
- these tests can run on OpenJDK and I am very thankful for that
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
-
URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{
matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
- run: ant $OPTS -f platform/core.network test
-
- - name: platform/api.scripting
- run: ant $OPTS -f platform/api.scripting test
Review Comment:
- Graal.js is no longer part of GraalVM
- it is a normal Maven library
- hence testing this module on any OpenJDK21+ is enough
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
Review Comment:
Yeah, since GraalVM for JDK 21+ there is no difference between OpenJDK and
GraalVM with respect to Graal.js except speed (peak performance of JavaScript).
NetBeans don't need peak performance of JavaScript for the usecases tested
here-in...
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') ||
contains(github.event.pull_request.labels.*.name, 'ci:all-tests') ||
github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
-
URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{
matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
- run: ant $OPTS -f platform/core.network test
-
- - name: platform/api.scripting
- run: ant $OPTS -f platform/api.scripting test
-
- - name: ide/libs.graalsdk
- run: ant $OPTS -f ide/libs.graalsdk test
-
- - name: webcommon/libs.graaljs
- run: ant $OPTS -f webcommon/libs.graaljs test
-
- - name: profiler/profiler.oql
- run: ant $OPTS -f profiler/profiler.oql test
Review Comment:
- profilier is using some JavaScript integration
- as Graal.js is no longer distributed as part of GraalVM
- testing on any OpenJDK21+ is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
