neilcsmith-net commented on PR #8568: URL: https://github.com/apache/netbeans/pull/8568#issuecomment-4186857781
I'm (still) -0 on this, but won't block it. I still don't see reasoning where the original code, minus the sibling check, is doing something wrong. Still, please ensure this is rebased and squashed before merging if it is. Has it been checked that this behaves correctly with inner / nested classes as per 236056? Unfortunately the test in that issue no longer exists to check against. Might want to consider whether `fqMethodName` should include the opening `(` given the use of `String::contains`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
