GitHub user mbien added a comment to the discussion: CodeLens-style reference 
count hint to the NetBeans Java editor.

> Feature scope

sounds good to me. First integration wouldn't have to cover all aspects (e.g 
LSP server) as long the implementation doesn't make future extension impossible 
which is probably not the case. Its good to keep scope small at first.

> UI direction

This would be NetBeans first inline hint which is drawn between lines I 
believe. I know this is popular and don't have anything against it, but I 
believe it would be worth considering a usage mode which does not rely on 
inline text too. Lets say it would work analog to the ctrl+click of the 
goto-declaration feature, but backwards, opening the usage popup instead. This 
mode would also avoid some of the performance concerns since it is 
lazy/on-demand. But since you already started with inline hints, its probably 
too late to reduce the scope to simple popup action first - which would likely 
be a smaller change. Lets see how the code looks we can add that later too.

 > Is the popup-on-click interaction preferred over directly opening Find 
 > Usages?

popup is probably the most convenient solution here.

> opens a popup on click, with an option to open the full Find Usages UI

right, you seem to have already accounted for that. User can still chose based 
on preference to get the full tree view -> excellent

> Performance expectations

this is something we _likely_ can't enable by default for now since performance 
wouldn't be predictable. (knowing how find usages works atm 
https://github.com/apache/netbeans/pull/8957).

But inline hints are already off by default and mapped to a hotkey, so it would 
already be covered I think.

feel free to open a draft PR - even if it isn't done yet.

GitHub link: 
https://github.com/apache/netbeans/discussions/9318#discussioncomment-16431861

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: 
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to