neilcsmith-net commented on PR #9303: URL: https://github.com/apache/netbeans/pull/9303#issuecomment-4170295858
> I have `--splash` code pulled out locally already (from Splash class) but its just a few lines, most of it is the comment. I don't plan to actually do that here since the windows platform launcher has splash code in it which I won't touch. OK, I checked the splash behaviour and it isn't opening another window but rendering into the existing splash as before, so this is still kind of functional if never used. Removing the code in here would be more than the comment though - there's lots of `comp == null` or different graphics checks that are related to supporting both rendering targets. The launcher code isn't hit if the splash file isn't in the cache, and even if there is an image there it would be immediately closed by the window in here opening. Still, happy with how it is now, too. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
