neilcsmith-net commented on issue #9270: URL: https://github.com/apache/netbeans/issues/9270#issuecomment-4149964402
Documentation by @hxreborn looks good to me. I don't know if `Lookup` itself has issues. Perhaps `Lookup.Template` could be a concern. And the default default lookup in there extends `ProxyLookup`, which does have various bits of collection code using equals and hashes. There are numerous lookup subclasses throughout the IDE, some doing things like deduplication via equals. My point was more that `Lookup` itself is at the root of a bunch of things that may exhibit questionable behaviour with mutating equals / hash, and therefore the documentation makes more sense there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
