matthiasblaesing commented on code in PR #9297:
URL: https://github.com/apache/netbeans/pull/9297#discussion_r2995433428
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/StartTask.java:
##########
@@ -739,6 +744,40 @@ private void appendStartupExtenderParams(List<String>
optList) {
}
}
+ /**
+ * Appends module path arguments required for GlassFish 7.1 and later.
+ * <p/>
+ * GlassFish 7.1+ requires {@code --module-path} and {@code --add-modules}
+ * JVM arguments to boot correctly.
+ * <p/>
+ * @param optList JVM options list to append arguments to.
+ */
+ private void appendGlassFish71PlusArgs(List<String> optList) {
+ GlassFishVersion version = instance.getVersion();
+ if (version != null && GlassFishVersion.ge(version,
GlassFishVersion.GF_7_1_0)) {
+ String glassfishRoot = instance.getGlassfishRoot();
+ if (glassfishRoot != null) {
+ optList.add("--module-path");
+ optList.add(glassfishRoot + "/lib/bootstrap");
+ optList.add("--add-modules");
+ optList.add("ALL-MODULE-PATH");
+ }
+ }
+ }
+
+ /**
+ * Appends additional JVM options configured for this server instance.
+ * <p/>
+ * @param optList JVM options list to append arguments to.
+ */
+ private void appendConfiguredJvmOptions(List<String> optList) {
+ String jvmOptions = instance.getJvmOptions().trim();
+ if (!jvmOptions.isEmpty()) {
+ String[] tokens = jvmOptions.split("\\s+");
Review Comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
