matthiasblaesing commented on PR #4485: URL: https://github.com/apache/netbeans/pull/4485#issuecomment-4057651974
@Chris2011 I ran tests locally and they also error out for me. I wanted to look into this, but then I noticed, that there are changes that make no sense to me when looking at the title of the PR "Add HTML rule and hint+fix for missing alt attribute for tag img, applet and area". Why are there changes to `HtmlHintsProvider.java` and `HtmlRuleContext.java`? Given that tests break that are not tied to the new functionalilty, I would look at these first. And the first question I would raise: Are the changes needed? I think I see a different bug being fixed here (missing cancelability), but I would try to make this minimal and split out, what is not strictly needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
