matthiasblaesing commented on code in PR #9268:
URL: https://github.com/apache/netbeans/pull/9268#discussion_r2932843686
##########
php/libs.javacup/nbproject/project.xml:
##########
@@ -32,7 +32,7 @@
</friend-packages>
<class-path-extension>
<runtime-relative-path>ext/java-cup-11a.jar</runtime-relative-path>
- <binary-origin>external/java-cup-11a.jar</binary-origin>
+ <binary-origin>external/java-cup-0.11a.jar</binary-origin>
Review Comment:
Yes I try to keep the changes to the sensible minimum. We control the
runtime name (see `project.properties`), just the built-time version changes.
For the `php.editor` reference. Yeah - thanks for catching that. As that
area is touched by another PR, I rebases this onto that PR. So basicly this
will need to wait for
- #9113 to be merged by @haidubogdan and
- #9264 to be reviewed and merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
