ramanathan1504 commented on PR #4359:
URL: https://github.com/apache/logging-log4j2/pull/4359#issuecomment-6287650665
@efegokdemir
No test covers the `equalsIgnoreCase` change in `getPassword`. With a `null`
password the JDK loads `keyStore-nopass.p12` without its certificate.
Can `SslConfigurationFactoryTest` load that file with an empty
`log4j2.keyStorePassword` and no type, and check the certificate is there? The
build needs JDK 17 to run the tests locally. `BUILDING.adoc` has the setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
