Shekharrajak commented on code in PR #4395:
URL: https://github.com/apache/logging-log4j2/pull/4395#discussion_r4306430783
##########
log4j-cassandra/src/main/java/org/apache/logging/log4j/cassandra/CassandraManager.java:
##########
@@ -172,7 +178,11 @@ public CassandraManager createManager(final String name,
final FactoryData data)
.addContactPointsWithPorts(data.contactPoints)
.withClusterName(data.clusterName);
if (data.useTls) {
- builder.withSSL();
+ if
(PropertiesUtil.getProperties().getBooleanProperty(VERIFY_HOST_NAME_PROPERTY,
false)) {
Review Comment:
I think instead of this we should start using the latest version
https://mvnrepository.com/artifact/org.apache.cassandra/java-driver-core/4.19.4
`com.datastax.oss.driver.api.core.CqlSession` API
and then something like
```
builder.withSslEngineFactory(new ProgrammaticSslEngineFactory(
SSLContext.getDefault(),
null,
verifyHostName));
```
Ref
https://github.com/Shekharrajak/cassandra-java-driver/blob/trunk/core/src/main/java/com/datastax/oss/driver/api/core/ssl/ProgrammaticSslEngineFactory.java#L80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
