swebb2066 commented on code in PR #775:
URL: https://github.com/apache/logging-log4cxx/pull/775#discussion_r4267642184
##########
src/main/cpp/fileoutputstream.cpp:
##########
@@ -28,27 +28,45 @@ using namespace LOG4CXX_NS::helpers;
struct FileOutputStream::FileOutputStreamPrivate
{
FileOutputStreamPrivate(const LogString& filename)
- : path(filename)
+ : path(filename), logappend(false)
{}
File path;
Pool pool;
apr_file_t* fileptr{ nullptr };
+ bool logappend;
void open(bool append);
+ void openAsTruncatedIfAlreadyExists(bool append);
Review Comment:
Remove the `bool append` parameters and use `this->logAppend` in the open
methods.
##########
src/main/cpp/fileoutputstream.cpp:
##########
@@ -28,27 +28,45 @@ using namespace LOG4CXX_NS::helpers;
struct FileOutputStream::FileOutputStreamPrivate
{
FileOutputStreamPrivate(const LogString& filename)
- : path(filename)
+ : path(filename), logappend(false)
Review Comment:
Add a `bool append` parameter to the constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
