zsewasdsdsd commented on PR #4363: URL: https://github.com/apache/logging-log4j2/pull/4363#issuecomment-6159868754
Thanks for the review! I've addressed the requested changes in commit `5dc9ca8`: - Added `testNamingExceptionIsRethrown()` to verify that a failed `InitialContext` creation propagates as `IllegalStateException`. - Added `testCloseClosesContext()` to verify that closing the manager closes the underlying JNDI context. - Updated the changelog to reference both the issue and this PR. The updated tests and implementation are pushed to this PR. Could you please take another look when you have time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
