ppkarwasz commented on code in PR #4392:
URL: https://github.com/apache/logging-log4j2/pull/4392#discussion_r4259591386
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager.java:
##########
@@ -762,6 +764,13 @@ private boolean rollover(final RolloverStrategy strategy) {
}
}
+ private static ScheduledExecutorService createAsyncExecutor(final
ThreadFactory threadFactory) {
+ final ScheduledThreadPoolExecutor executor = new
ScheduledThreadPoolExecutor(1, threadFactory);
Review Comment:
In practice this executor will run only one task per thread.
```suggestion
final ScheduledThreadPoolExecutor executor = new
ScheduledThreadPoolExecutor(0, threadFactory);
```
After this change we can drop `allowCoreThreadTimeOut`: there are no more
core threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
