rm5248 commented on PR #774: URL: https://github.com/apache/logging-log4cxx/pull/774#issuecomment-6080065570
This seems unlikely to happen, but could there be a threading issue if two threads are using the same object at once? example: - Thread A is doing processing with a `shared_ptr`and the ref count is 1 - Thread B is doing processing with a `shared_ptr` but doesn't have the ref count incrementing - Thread A is finished with the `shared_ptr`, decrements the ref count and deletes the object - Thread B is not done and tries to access the (now invalid) `shared_ptr` I think in most of the methods that have changed this is not an issue, because it will assign the parameter to an instance variable, thus incrementing the ref count. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
