garydgregory commented on code in PR #21: URL: https://github.com/apache/logging-site/pull/21#discussion_r2987924604
########## src/site/antora/modules/ROOT/pages/security/faq.adoc: ########## @@ -0,0 +1,123 @@ +//// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +//// + += Frequently Reported Vulnerabilities + +This page documents issues that are **frequently reported** in Logging Services software but are **not considered vulnerabilities** according to our xref:security.adoc#threat-model[threat model]. + +These reports often stem from valid concerns in specific contexts, but reflect common misunderstandings about how logging systems are designed to operate and what security guarantees they provide. + +The goal of this FAQ is to: + +* Clarify common misconceptions +* Explain why these reports fall outside our threat model +* Help you make informed decisions when configuring logging + +[NOTE] +==== +This document is not intended to dismiss security concerns, but to provide context and guidance. +Depending on your environment, some of these topics may still warrant **defensive configuration**. +==== + +[#crlf-injection] +== https://cwe.mitre.org/data/definitions/93.html[CWE-93: CRLF Injection] + +A frequently reported issue is the presence of CR (`\r`) and LF (`\n`) characters in layout output. +In most logging contexts this behavior is **intentional** and **not considered a vulnerability**. + +=== Pattern layout + +**Claim**: Pattern layout is vulnerable to CRLF injection because it does not escape CRLF characters. + +Pattern layout is an **unstructured text format**. Review Comment: Broken styling? `**unstructured` -> `unstructured` ########## src/site/antora/modules/ROOT/pages/security/faq.adoc: ########## @@ -0,0 +1,123 @@ +//// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +//// + += Frequently Reported Vulnerabilities + +This page documents issues that are **frequently reported** in Logging Services software but are **not considered vulnerabilities** according to our xref:security.adoc#threat-model[threat model]. + +These reports often stem from valid concerns in specific contexts, but reflect common misunderstandings about how logging systems are designed to operate and what security guarantees they provide. + +The goal of this FAQ is to: + +* Clarify common misconceptions +* Explain why these reports fall outside our threat model +* Help you make informed decisions when configuring logging + +[NOTE] +==== +This document is not intended to dismiss security concerns, but to provide context and guidance. +Depending on your environment, some of these topics may still warrant **defensive configuration**. +==== + +[#crlf-injection] +== https://cwe.mitre.org/data/definitions/93.html[CWE-93: CRLF Injection] + +A frequently reported issue is the presence of CR (`\r`) and LF (`\n`) characters in layout output. Review Comment: I would clarify "layout output" by listing the ones we provide. ########## src/site/antora/modules/ROOT/pages/security/faq.adoc: ########## @@ -0,0 +1,123 @@ +//// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +//// + += Frequently Reported Vulnerabilities + +This page documents issues that are **frequently reported** in Logging Services software but are **not considered vulnerabilities** according to our xref:security.adoc#threat-model[threat model]. + +These reports often stem from valid concerns in specific contexts, but reflect common misunderstandings about how logging systems are designed to operate and what security guarantees they provide. + +The goal of this FAQ is to: + +* Clarify common misconceptions +* Explain why these reports fall outside our threat model +* Help you make informed decisions when configuring logging + +[NOTE] +==== +This document is not intended to dismiss security concerns, but to provide context and guidance. +Depending on your environment, some of these topics may still warrant **defensive configuration**. +==== + +[#crlf-injection] +== https://cwe.mitre.org/data/definitions/93.html[CWE-93: CRLF Injection] + +A frequently reported issue is the presence of CR (`\r`) and LF (`\n`) characters in layout output. +In most logging contexts this behavior is **intentional** and **not considered a vulnerability**. Review Comment: I don't think bold is needed or whatever `**` means here if it's different from Markdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
