ppkarwasz commented on issue #4034: URL: https://github.com/apache/logging-log4j2/issues/4034#issuecomment-4088442605
> > Having a couple more libraries at compile time beats breaking builds for users the need to use -Werror by policy. > > [@ppkarwasz](https://github.com/ppkarwasz) I understand, but I - personally - still do not agree. I seldomly have seen `-Werror` in use with Java, so I'd say it is the minority of the users. So you make build for the majority of your users slower just to work-around a Java Compiler bug for some of your users that are just hit by the bug due to their individual configuration and imho should apply the work-around of adding those libraries to their compile classpaths. Can you quantify the performance difference in the compilation? Is it imputable to the additional download time of the dependencies or do you see a significant performance difference during the compilation? I agree with you that only a minority of users compiles with `-Werror`, but that minority has reached out multiple times asking to fix it on our end. There are company policies that developers can not easily overcome (even if they don't make sense), for example Spring Boot couldn't upgrade to version `2.25.1` due to a log event of severity `ERROR` being generated during the build (#3779). In comparison, a compilation slowdown is a barely noticeable problem. > That _is_ the same issue, or at least the same root cause and also fixed by the same PR. You are right, I didn't read the PR in detail. > Besides that in the comment you linked to you wrote that you will _not_ add those dependencies, but you did now. :-) We didn't add them to the **runtime** classpath, which is, in my opinion, the most relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
