vy commented on code in PR #4049:
URL: https://github.com/apache/logging-log4j2/pull/4049#discussion_r2871395729
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java:
##########
@@ -384,6 +385,101 @@ void
depth_and_package_limited_output_should_match_2(final DepthTestCase depthTe
" ... 3 more",
"Caused by: [CIRCULAR REFERENCE:
foo.TestFriendlyException: r_c [localized]]"));
}
+
+ /**
+ * Verifies that the extended stack trace renderer does not propagate
+ * {@link Throwable} when a class in the stack trace cannot be
resolved.
+ *
+ * @see <a
href="https://github.com/apache/logging-log4j2/issues/4028";>#4028</a>
+ */
+ @Test
+ @Issue("https://github.com/apache/logging-log4j2/issues/4028";)
+ void rendering_should_succeed_with_nonexistent_class_in_stack_trace() {
Review Comment:
I've put some more thought into this issue, and this particular test feels
like an after-thought. Would you mind removing this particular test method,
extending `TestFriendlyException` with [this
patch](https://github.com/user-attachments/files/25679863/TestFriendlyException.patch)
to contain a stack trace element of a non-existent class, and adapt
`ThrowablePatternConverterTest` and its subclasses to make sure they pass,
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
