ppkarwasz commented on code in PR #3703:
URL: https://github.com/apache/logging-log4j2/pull/3703#discussion_r2120309313
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilder.java:
##########
@@ -61,6 +61,15 @@ public interface ConfigurationBuilder<T extends
Configuration> extends Builder<T
*/
ConfigurationBuilder<T> add(CustomLevelComponentBuilder builder);
+ /**
+ * Adds a top level component.
+ * @param builder The ComponentBuilder with all of its attributes and sub
components set.
+ * @return this builder instance.
+ */
+ default ConfigurationBuilder<T> addComponent(ComponentBuilder<?> builder) {
+ throw new UnsupportedOperationException();
+ }
Review Comment:
Does it also fail if you annotate the class with
`@org.osgi.annotation.versioning.ProviderType`? Adding an abstract method is a
breaking change, but only for those (providers) that implement the interface,
for consumers it is a minor change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
