ppkarwasz commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2918440584
> With 24 files changed here, I might have missed the answer to the following questions, so apologies if I did (AFK, phone): It appears that test configuration files have been updated to use the new format, but how is the classic format tested then? The new format should be tested in new test fixtures to guarantee that nothing will break existing user configurations. The classic configuration format (where `databaseName` and `collectionName` are inferred from the connection string) is still tested via the unit test [`MongoDbProviderTest`](https://github.com/apache/logging-log4j2/blob/9dcff7c551661f905f82bb74c1f1eb2141d3012f/log4j-mongodb/src/test/java/org/apache/logging/log4j/mongodb/MongoDbProviderTest.java). This test explicitly covers the fallback behavior, ensuring that default values are correctly derived when those parameters are not explicitly set. I believe this provides sufficient coverage to confirm that existing user configurations remain supported. > The site docs mention that the new format overrides the old one (good doc change) but does the Javadoc reflect that as well? Great point — thanks for catching that! 👍 The main purpose of this PR is to address a mismatch between the Javadoc for `ConnectionString`, which allows specifying a collection name, and the broader MongoDB documentation, which doesn’t cover that case. We should definitely ensure that our Javadoc clearly reflects the changes in the configuration format. BTW: the Log4j plugin reference is auto-generated from the Javadoc of the builder classes. So updating the Javadoc will directly improve the plugin reference too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
