LeadAssimilator commented on issue #247: URL: https://github.com/apache/logging-log4net/issues/247#issuecomment-2902629854
Yes, it works correctly now thanks! You may wish to revisit the caching in general and consider making it optional or removing it. In my testing on net8, you need a log rate of at least ~1/65ms on average to match the overhead introduced by the caching logic vs. directly writing the time to the text writer each call. Exceeding 1/65ms on average seems rather unlikely in most applications. While the caching would speed up bursts of many statements within the same second, that would really have to be the overwhelmingly common case. Not to mention my tests were single threaded - for multithreaded logging, the caching logic's overhead would only increase when there is contention on the dictionary (though that could be mitigated by making the dictionary thread-local). Unless I'm missing something, I generally think this caching logic provides no material benefit to most applications (doesn't ever pay for its cpu cycle overhead cost) and really only serves to boost the times of naive/unrealistic benchmarks to the detriment of real total/average performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
