ppkarwasz commented on code in PR #3512:
URL: https://github.com/apache/logging-log4j2/pull/3512#discussion_r1981325660
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/filter/AbstractFilter.java:
##########
@@ -43,16 +45,30 @@ public abstract static class AbstractFilterBuilder<B
extends AbstractFilterBuild
public static final String ATTR_ON_MISMATCH = "onMismatch";
public static final String ATTR_ON_MATCH = "onMatch";
+ /**
+ * The action to perform when a match occurs.
+ */
@PluginBuilderAttribute(ATTR_ON_MATCH)
- private Result onMatch = Result.NEUTRAL;
+ protected Result onMatch = Result.NEUTRAL;
+ /**
+ * The action to perform when a mismatch occurs.
+ */
@PluginBuilderAttribute(ATTR_ON_MISMATCH)
- private Result onMismatch = Result.DENY;
+ protected Result onMismatch = Result.DENY;
Review Comment:
There is already a `getOnMismatch()`, no need to expose the field too.
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/filter/AbstractFilter.java:
##########
@@ -43,16 +45,30 @@ public abstract static class AbstractFilterBuilder<B
extends AbstractFilterBuild
public static final String ATTR_ON_MISMATCH = "onMismatch";
public static final String ATTR_ON_MATCH = "onMatch";
+ /**
+ * The action to perform when a match occurs.
+ */
@PluginBuilderAttribute(ATTR_ON_MATCH)
- private Result onMatch = Result.NEUTRAL;
+ protected Result onMatch = Result.NEUTRAL;
Review Comment:
There is already a `getOnMatch()`, no need to expose the field too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
