vy commented on code in PR #3553:
URL: https://github.com/apache/logging-log4j2/pull/3553#discussion_r2007102679
##########
src/site/antora/modules/ROOT/partials/manual/api-best-practice-dont-use-string-concat.adoc:
##########
@@ -34,3 +29,10 @@ Imagine `userId` being provided by the user with the
following content:
----
/* GOOD */ LOGGER.info("failed for user ID `{}`", userId);
----
+
+* [x] Use message lambdas
++
+[source,java]
+----
+/* GOOD */ LOGGER.info(() -> "failed for user ID: " + userId);
Review Comment:
@ppkarwasz, I think this is a foot gun. It'd be very hard to distinguish for
inexperienced users, which is the chief audience of this guide, why it is fine
to do string concatenation here, whereas before it was not. IMHO, this should
not be supported by the API in the first place, but anyway. In short, unless
you strongly object, can we remove this part, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
