vy commented on PR #363: URL: https://github.com/apache/logging-parent/pull/363#issuecomment-2752301426
In the context of Log4j, a build takes ~30m and the site phase takes ~1m. In this PR, even though it seems like we save ~1m in CI at the cost of avoiding site on non-Linux platforms, we actually don't – because Linux will still be running the site build, and hence, the result will still be the same: *Before:* maxTime(Linux build + site, Windows build + site, MacOS build + site) *After:* maxTime(Linux build + site, Windows build, MacOS build) Let's assume I'm wrong and you're indeed saving ~1m. For one, that is a negligible gain, and, IMHO, a loss in disguise given what we're sacrificing. Second, you can also save that amount by just improving 1-2 tests in Log4j. I think ensuring site builds on all supported platforms have a merit and I want to keep it. Could we keep this, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
