vy commented on code in PR #3474:
URL: https://github.com/apache/logging-log4j2/pull/3474#discussion_r1966567310
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/InternalLoggerRegistry.java:
##########
@@ -142,12 +188,12 @@ public Logger computeIfAbsent(
final MessageFactory messageFactory,
final BiFunction<String, MessageFactory, Logger> loggerSupplier) {
- // Check arguments
Review Comment:
@Suvrat1629, please revert all changes that are irrelevant in the context of
this PR – just like the one on this line. To make sure you indeed implemented
what I asked for, please compare your branch with `2.x` (i.e., `git diff
origin/2.x`) before submitting them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
