ppkarwasz commented on issue #3088: URL: https://github.com/apache/logging-log4j2/issues/3088#issuecomment-2671314952
It's a little bit more complex than that. What we want to achieve is: - if a required configuration attribute is missing, we want to issue an `ERROR` only once. For coherence, we want all configuration formats to use the same log statement (if possible). - if some Java properties are not taken into account we want to issue a `WARN` message. Returning to the examples above: - We don't need to check if an appender has a `name` property. As it turns out, if we omit the check, `AbstractAppender.Builder` will issue an `ERROR` log statement. - We **do** need to check if an appender has a `type` property. If it doesn't, we can not create a `Component` for that appender and **all** the Java properties for that appender will be ignored. We need to warn the user about that. Summarizing: when your remove a `throw` statement, you need to check what happens and see if an appropriate log statement is **already** being published. If not, you need to add your own. You also need to make sure that **all** the properties in the file have been translated into `Component`s (actually `ComponentBuilder`s). If something is left, you should warn users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
