vy commented on code in PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#discussion_r1958757105
########## src/site/antora/modules/ROOT/examples/manual/appenders/database/nosql-mongo-keys.json: ########## Review Comment: @ppkarwasz, I've made some research: > the [official connection string](https://www.mongodb.com/docs/manual/reference/connection-string/) does not contain any segment that could be **unambiguously** interpreted as `databaseName` or `collectionName`. I don't know what _"the official connection string"_ exactly means, but the [`ConnectString`](https://mongodb.github.io/mongo-java-driver/5.3/apidocs/mongodb-driver-core/com/mongodb/ConnectionString.html) of the MongoDB Java Driver supports `database.collection` notation. Plus, this is, AFAICT, unambiguous, since [dots are not allowed in database names](https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions). > Using three configuration properties is more verbose, but it is easier to understand and less Log4j-specific (or Java-specific). I still agree with the idea of using a separate attribute to denote the collection name, though wanted to add extra context for the records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
