JWT007 commented on code in PR #3463:
URL: https://github.com/apache/logging-log4j2/pull/3463#discussion_r1958484142
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java:
##########
@@ -123,6 +115,40 @@ public String toString() {
* The regular expression to match.
* @param patternFlags
* An array of Strings where each String is a {@link
Pattern#compile(String, int)} compilation flag.
+ * (no longer used - pattern flags can be embedded in
regex-expression.
+ * @param useRawMsg
+ * If {@code true}, for {@link ParameterizedMessage}, {@link
StringFormattedMessage}, and {@link MessageFormatMessage}, the message format
pattern; for {@link StructuredDataMessage}, the message field will be used as
the match target.
+ * @param match
+ * The action to perform when a match occurs.
+ * @param mismatch
+ * The action to perform when a mismatch occurs.
+ * @return The RegexFilter.
+ * @throws IllegalAccessException When there is no access to the
definition of the specified member.
+ * @throws IllegalArgumentException When passed an illegal or
inappropriate argument.
+ * @deprecated use {@link #createFilter(String, Boolean, Result, Result)}
+ */
+ @Deprecated
+ // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
+ public static RegexFilter createFilter(
Review Comment:
@ppkarwasz I significantly reworked this one - please review if OK
I reworked it so that all config parameters are accessible via getters (i.e.
'regex') - this sort of comes from my own prroblems with these classes where
config parameters are not accessible later making it impossible to see *how*
the element was configured (i.e. to recreate config at runtime). If this is OK
I would probably make some new tickets to do the same for some other
configuration items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
