rm5248 commented on code in PR #477:
URL: https://github.com/apache/logging-log4cxx/pull/477#discussion_r1942155172
##########
src/main/cpp/stringhelper.cpp:
##########
@@ -30,17 +30,18 @@ using namespace LOG4CXX_NS::helpers;
bool StringHelper::equalsIgnoreCase(const LogString& s1, const logchar* upper,
const logchar* lower)
{
- for (LogString::const_iterator iter = s1.begin();
- iter != s1.end();
- iter++, upper++, lower++)
+ for (auto& item : s1)
Review Comment:
perhaps make this `const auto&` to match the `const_iterator` from before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
