jbb01 commented on issue #3423:
URL: 
https://github.com/apache/logging-log4j2/issues/3423#issuecomment-2626397438

   Unfortunately, I'm not quite sure what "the solution" is. The simplest 
approach would be to just remove the exclusion pattern. The resulting XSD will 
contain the missing `<simpleType>` for `Charset` as well as a few other types 
(`Class`, `InetAddress`, `URL`, `Pattern`) and also the missing attributes: 
`HttpAppender.url`, `ColumnMapping.columnType`, `ColumnMapping.type`, 
`SocketAddress.host`, `RegexReplacement.regex`, as well as the `charset` 
attribute for 12 appenders and layouts in total. This change, however, also 
results in the generation of `<group>`s for `Serializable`, `Cloneable`, 
`Iterable`, `Object`, `Runnable` and `Comparator`, which is probably what the 
exclusion tried to avoid in the first place. If you think the upsides outweigh 
the downsides, I'll gladly submit a PR with this solution.
   
   Based on this first approach, you could also explicitly exclude only the 
`<group>` types or include the attribute types (though excludes take priority 
over includes, so including some types from `java.*` while excluding all others 
might result in an ugly regex) to avoid generation of the groups. This approach 
is not maintenance-free, as new attribute or group types would have to be 
manually added to the list.
   
   The in my opinion best, but probably also most difficult approach, would be 
to allow types based on the available `TypeConverter`s but that would requiring 
knowing (or better detecting) the complete list of type converters available at 
build time and configure the `log4j-docgen-maven-plugin` accordingly. I would 
not know how to go about implementing this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to