rm5248 commented on code in PR #465:
URL: https://github.com/apache/logging-log4cxx/pull/465#discussion_r1936421191
##########
src/fuzzers/bash/oss-fuzz-build.sh:
##########
@@ -38,16 +38,25 @@ mkdir -p "$outputDir"
# Switch to the project directory (by referencing from the script directory)
cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && cd ../../..
-# Build the project
-mkdir -p build && cd $_
-cmake \
- -DBUILD_SHARED_LIBS=OFF \
- -DBUILD_TESTING=OFF \
- -DBUILD_EXAMPLES=OFF \
- -DBUILD_FUZZERS=ON \
- ..
-cmake --build . -j
-
-# Copy executables & resources
-find src/fuzzers/cpp -maxdepth 1 -executable -type f -exec cp -v {}
"$outputDir/" \;
-cp -v ../src/fuzzers/resources/* "$outputDir/"
+# Build a fuzzer with each encoding
+declare -a encodings=("utf-8" "wchar_t")
+
+for encoding in "${encodings[@]}"
+do
+ echo heeeeere
+ # Build the project
+ mkdir -p build && cd $_
Review Comment:
I'm not sure if this will cause a problem in this case, but sometimes cmake
needs to clear the build dir between runs when changing certain variables(I
think if the variable is cached). Do we need separate build directories and/or
to clear out the build directory between runs?
##########
src/fuzzers/bash/oss-fuzz-build.sh:
##########
@@ -38,16 +38,25 @@ mkdir -p "$outputDir"
# Switch to the project directory (by referencing from the script directory)
cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && cd ../../..
-# Build the project
-mkdir -p build && cd $_
-cmake \
- -DBUILD_SHARED_LIBS=OFF \
- -DBUILD_TESTING=OFF \
- -DBUILD_EXAMPLES=OFF \
- -DBUILD_FUZZERS=ON \
- ..
-cmake --build . -j
-
-# Copy executables & resources
-find src/fuzzers/cpp -maxdepth 1 -executable -type f -exec cp -v {}
"$outputDir/" \;
-cp -v ../src/fuzzers/resources/* "$outputDir/"
+# Build a fuzzer with each encoding
+declare -a encodings=("utf-8" "wchar_t")
+
+for encoding in "${encodings[@]}"
+do
+ echo heeeeere
Review Comment:
debug message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
