swebb2066 commented on code in PR #454: URL: https://github.com/apache/logging-log4cxx/pull/454#discussion_r1922919453
########## src/fuzzers/cpp/HTMLLayoutFuzzer.cpp: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "stdint.h" +#include <log4cxx/logstring.h> +#include <log4cxx/ndc.h> +#include <log4cxx/helpers/stringhelper.h> +#include <fuzzer/FuzzedDataProvider.h> +#include <log4cxx/mdc.h> +#include <log4cxx/htmllayout.h> + +using namespace log4cxx; +using namespace log4cxx::helpers; +using namespace log4cxx::spi; + +extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { + // Setup HTMLLayout + HTMLLayout layout; + log4cxx::helpers::Pool p; + + FuzzedDataProvider fdp(data, size); + + // Optional locationinfo + if (fdp.ConsumeBool()) { + layout.setOption(LOG4CXX_STR("LOCATIONINFO"), LOG4CXX_STR("locationinfo")); + } + // Optional threadinfo + if (fdp.ConsumeBool()) { + layout.setOption(LOG4CXX_STR("TITLE"), LOG4CXX_STR("title")); + } + + // Header + if (fdp.ConsumeBool()) { + std::string headerStr = fdp.ConsumeRandomLengthString(); + layout.appendHeader(LOG4CXX_STR(headerStr), p); + } + + // Create random strings we need later + std::string key1 = fdp.ConsumeRandomLengthString(); + std::string val1 = fdp.ConsumeRandomLengthString(); + std::string key2 = fdp.ConsumeRandomLengthString(); + std::string val2 = fdp.ConsumeRandomLengthString(); + std::string key3 = fdp.ConsumeRandomLengthString(); + std::string val3 = fdp.ConsumeRandomLengthString(); + std::string key4 = fdp.ConsumeRandomLengthString(); + std::string val4 = fdp.ConsumeRandomLengthString(); + std::string ndcMessage = fdp.ConsumeRandomLengthString(); + std::string loggerStr = fdp.ConsumeRandomLengthString(); + std::string content = fdp.ConsumeRemainingBytesAsString(); Review Comment: But [FuzzedDataProvider::ConsumeRandomLengthString(size_t max_length)](https://github.com/llvm/llvm-project/blob/0ec153b9fde70da3b46292d0627b3896e0bdceab/compiler-rt/include/fuzzer/FuzzedDataProvider.h#L153-L178) will consume all `remaining_bytes_`. After modifying XMLLayoutFuzz.cpp as follows: ``` diff --git a/src/fuzzers/cpp/XMLLayoutFuzzer.cpp b/src/fuzzers/cpp/XMLLayoutFuzzer.cpp index 786af637..731053d6 100644 --- a/src/fuzzers/cpp/XMLLayoutFuzzer.cpp +++ b/src/fuzzers/cpp/XMLLayoutFuzzer.cpp @@ -20,8 +20,10 @@ #include <log4cxx/ndc.h> #include <log4cxx/xml/xmllayout.h> #include <log4cxx/helpers/stringhelper.h> +#include <log4cxx/helpers/loglog.h> #include <fuzzer/FuzzedDataProvider.h> #include <log4cxx/mdc.h> +#include <log4cxx/hexdump.h> extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { // Setup XMLLayout @@ -30,9 +32,13 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { // Create random strings FuzzedDataProvider fdp(data, size); std::string key1 = fdp.ConsumeRandomLengthString(); + log4cxx::helpers::LogLog::debug(LOG4CXX_STR("key1=") + log4cxx::hexdump(key1.c_str(), key1.size())); std::string val1 = fdp.ConsumeRandomLengthString(); + log4cxx::helpers::LogLog::debug(LOG4CXX_STR("val1=") + log4cxx::hexdump(val1.c_str(), val1.size())); std::string key2 = fdp.ConsumeRandomLengthString(); + log4cxx::helpers::LogLog::debug(LOG4CXX_STR("key2=") + log4cxx::hexdump(key2.c_str(), key2.size())); std::string val2 = fdp.ConsumeRandomLengthString(); + log4cxx::helpers::LogLog::debug(LOG4CXX_STR("val2=") + log4cxx::hexdump(val2.c_str(), val2.size())); std::string content = fdp.ConsumeRemainingBytesAsString(); log4cxx::LogString logger = LOG4CXX_STR("com.example.bar"); ``` I get output like this extract: ``` log4cxx: key1=00000000 0a 0a |..| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 f8 0a 0a |...| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 b8 0a 0a |...| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 b8 0a 0a 0a |....| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 b8 0a 0a 0a |....| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 41 |A| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 41 |A| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 41 |A| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 41 0a |A.| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 c1 0a |..| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 11 |.| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 11 |.| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 11 21 |.!| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 2a 21 |*!| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 2a 21 |*!| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 0a 0a |..| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 8a 0a |..| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 0a |.| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000010 00 00 00 00 00 00 00 00 00 00 00 00 |............| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000010 00 00 00 00 2c 00 00 00 00 00 00 00 |....,.......| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 08 |.| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 08 |.| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 08 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |...............| log4cxx: val1= log4cxx: key2= log4cxx: val2= log4cxx: key1=00000000 08 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |...............| log4cxx: val1= log4cxx: key2= log4cxx: val2= ``` What system are you using for your testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
