ppkarwasz commented on issue #3119: URL: https://github.com/apache/logging-log4j2/issues/3119#issuecomment-2563424332
@szegedi, > I have a fix at https://github.com/szegedi/nashorn/tree/fix-logging-2. Unfortunately, I had to revert part of your fix and reintroduce the DISABLED_LOGGER, although this time it is _explicitly_ disabled regardless of the underlying logging library. > > The logging in Nashorn is quite an architectural mess, as we need a Context (of which you can have more than one) to initialize a static (MethodHandleFactory.FUNC.) Right now all I have energy for is fixing it like this. Thank you for the help and the fix! I can confirm (a little bit late) that Nashorn 15.6 works correctly with Log4j Core. We introduced an integration test apache/logging-log4j-samples#251 to prevent regressions. The use of `DISABLED_LOGGER` is a perfect workaround for now: there are bugs on our side that cause an infinite recursion if Nashorn is used to filter log events and calls `Logger.isEnabledFor` at the same time (#3335) :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
