AlbaHerrerias opened a new pull request, #3289:
URL: https://github.com/apache/logging-log4j2/pull/3289

   We are from Neighbourhoodie, the implementation partner of the STF Bug 
Resilience Program. This work is part of our agreed Milestone 1. Upgrade from 
JUnit 4 to JUnit 5. This PR takes the changes introduced [in this 
PR](https://github.com/apache/logging-log4j2/pull/3061) and ports them into the 
`main` branch, [as 
requested](https://github.com/apache/logging-log4j2/pull/3225#issuecomment-2541173189).
   
   Most of the changes were not suitable:
   - Many tests  in `main` were already in JUnit 5
   - The tests were not equal between `2.x` and `main` (the tests in `main` 
need a separate and dedicated refactor)
   - `2.x` has test suites not present in `main` 
   
   Thank you!
   
   
   ## Checklist
   
   * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` 
otherwise
   * `./mvnw verify` succeeds (if it fails due to code formatting issues 
reported by Spotless, simply run `./mvnw spotless:apply` and retry)
   * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` 
directory
   * Tests for the changes are provided
   * [Commits are 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 (optional, but highly recommended)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to