rm5248 commented on code in PR #441: URL: https://github.com/apache/logging-log4cxx/pull/441#discussion_r1878136371
########## src/main/include/log4cxx/rolling/multiprocessrollingfileappender.h: ########## @@ -34,12 +34,12 @@ namespace rolling /** * A special version of the RollingFileAppender that acts properly with multiple processes */ -class LOG4CXX_EXPORT MultiprocessRollingFileAppender : public FileAppender Review Comment: I'm pretty sure this breaks the ABI(changing the class hierarchy), but the MultiprocessrollingFileAppender has never been tracked as part of the ABI because it is optional. Are we concerned about any ABI breakage or do we not care because it's optional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
