JWT007 opened a new issue, #3215:
URL: https://github.com/apache/logging-log4j2/issues/3215

   RegexReplacement#createRegexReplacement
   
   Static builder method returns `null`if the `regex`attribute is null, but 
although it logs an error it does not return `null` if the `replacement` 
attribute is `null`.
   
   ```
   public static RegexReplacement createRegexReplacement(
           @PluginAttribute("regex") final Pattern regex, 
@PluginAttribute("replacement") final String replacement) {
       if (regex == null) {
           LOGGER.error("A regular expression is required for replacement");
           return null;
       }
       if (replacement == null) {
           LOGGER.error("A replacement string is required to perform 
replacement");
       }
       // FIXME: should we use Matcher.quoteReplacement() here?
       return new RegexReplacement(regex, replacement);
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to