kelunik commented on issue #3068:
URL: 
https://github.com/apache/logging-log4j2/issues/3068#issuecomment-2404403858

   @rgoers Do you remember why you changed from modified time to creation time 
in 
https://github.com/apache/logging-log4j2/commit/e392c79274ab5cd545d59d7e8fa3b744c7367d16?
   
   Calling `file.lastModified()` in `initialFileTime` if the file doesn't exist 
doesn't seem to make sense.
   
   My fix proposal would be to revert this back to `lastModified()` and keep 
the `> 0` check and maybe (?) add a check that it's `<= 
System.currentTimeMillis()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to