vy commented on PR #3007: URL: https://github.com/apache/logging-log4j2/pull/3007#issuecomment-2377074733
Hey @ninetteadhikari! Thanks so much for the contribution! :heart_eyes: You're going in the right direction. Some guidelines you might benefit from: * Submit PRs per module * Make sure you read [the development guide](https://github.com/apache/logging-log4j2/blob/2.x/BUILDING.adoc#development) * Make sure `./mvnw verify -pl :<module-name>` passes before submitting the PR * Make sure you follow our coding conventions (`final` modifiers for variables, etc.) * Make sure the visibility of test classes are sufficiently decreased as you migrate to JUnit 5 (i.e., classes and methods can be package-local instead of `public`) * If you need to rewrite assertions, prefer AssertJ [fluent API] over JUnit [I will review the PR right away...] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
