ppkarwasz commented on code in PR #1141:
URL: https://github.com/apache/logging-log4j2/pull/1141#discussion_r1024236855


##########
src/site/markdown/maven-artifacts.md.vm:
##########
@@ -149,14 +149,29 @@ file. When you specify the version identifier in this 
section, you don't have to
 </dependencyManagement>
 ```
 
-To use this with Gradle, an additional [Gradle 
plugin](https://github.com/spring-gradle-plugins/dependency-management-plugin)
+Gradle 5.0+ supports importing Maven BOM as a 
[platform](https://docs.gradle.org/current/userguide/platforms.html#sub:bom_import)
+to align dependency versions.
+
+`build.gradle`
+
+```
+dependencies {
+  implementation 
platform('org.apache.logging.log4j:log4j-bom:${Log4jReleaseVersion}')
+
+  implementation 'org.apache.logging.log4j:log4j-api'
+  implementation 'org.apache.logging.log4j:log4j-core'

Review Comment:
   @grossws, the documentation you cited might be misleading: if someone 
develops custom plugins, `log4j-core` needs to be a compile dependency because 
custom plugins must reference implementation classes. As it is written right 
now someone might think that adding Log4j2 Core as compile dependency improves 
startup.
   
   I would remove that remark from the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to