[
https://issues.apache.org/jira/browse/LOG4J2-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542844#comment-17542844
]
Volkan Yazici commented on LOG4J2-3520:
---------------------------------------
Thanks for the report [~mdernst], you are right. Mind submitting a PR
implementing the 2nd approach, please? (Note that you can delete
{{toolchains-sample-*.xml}} files in the PR.)
> sample toolchains.xml files do not provide JDK 11
> -------------------------------------------------
>
> Key: LOG4J2-3520
> URL: https://issues.apache.org/jira/browse/LOG4J2-3520
> Project: Log4j 2
> Issue Type: Documentation
> Components: Documentation
> Affects Versions: 2.17.2
> Reporter: Michael Ernst
> Priority: Minor
>
> File `BUILDING.md` says to use one of these command-line arguments:
> {quote}
> [Macintosh] -t ./toolchains-sample-mac.xml
> [Windows] -t ./toolchains-sample-win.xml
> [Linux] -t ./toolchains-sample-linux.xml
> {quote}
> But those files are inconsistent with file
> `.github/workflows/maven-toolchains.xml`.
> I suggest that all these files be made consistent with one another.
> (It looks to me like `.github/workflows/maven-toolchains.xml` is probably the
> right one to copy from.)
> Alternately, a way to prevent such mismatches in the future is to delete the
> 3 "sample" toolchain files and change the instructions to say to set two
> environment variables (for example
> {quote}
> export JAVA_HOME_8_X64=$HOME/java/jdk8
> export JAVA_HOME_11_X64=$HOME/java/jdk11
> {quote}
> ) and then use
> {quote}
> --global-toolchains ".github/workflows/maven-toolchains.xml"
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
