vy commented on a change in pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r666004260
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java
##########
@@ -29,6 +32,11 @@
*/
private final NameAbbreviator abbreviator;
+ /**
+ * Cache of previously encountered inputs (keys) and conversion results
(values).
+ */
+ private final Map<String, String> conversionCache = new
ConcurrentHashMap<>();
Review comment:
We can use the cache size property set to `0` to disable the cache.
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java
##########
@@ -29,6 +32,11 @@
*/
private final NameAbbreviator abbreviator;
+ /**
+ * Cache of previously encountered inputs (keys) and conversion results
(values).
+ */
+ private final Map<String, String> conversionCache = new
ConcurrentHashMap<>();
Review comment:
We can use the cache size property set to `0` to disable the cache and
have a sane default there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
